Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 22 #23

Merged
merged 1 commit into from
May 5, 2021
Merged

Fix issue 22 #23

merged 1 commit into from
May 5, 2021

Conversation

khyperia
Copy link
Contributor

@khyperia khyperia commented May 5, 2021

Fixes #22. Make rust-side Passes enum match C++ side. The C++ side was updated in #15 but the Rust side was missed.

@khyperia
Fix issue 22
2e62adf 
Make rust-side Passes enum match C++ side. The C++ side was updated in
#15 but the Rust
side was missed.
@khyperia khyperia requested a review from Jake-Shadle May 5, 2021 07:41
@Jake-Shadle
Copy link
Member

Ahh nice, you found it! I think you just need to change Cargo.toml to have

[[test]]
name = "issue_22"
required-features = ["use-compiled-tools", "use-installed-tools"]

@mergify mergify bot merged commit 1f770d3 into main May 5, 2021
@mergify mergify bot deleted the fix-22 branch May 5, 2021 08:08
@Jake-Shadle
Copy link
Member

wtf mergify

@khyperia
Copy link
Contributor Author

khyperia commented May 5, 2021 •
edited
Loading

oof, what, haha

@msiglreith msiglreith mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpString is removed by compiled tools, but not installed tools
2 participants
@khyperia @Jake-Shadle