Suppress deprecated sprintf warnings #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation started failing after what I think was some Mac Xcode or system update (new compiler likely?).
This suppress this deprecation warning that failed the build:
```
warning: In file included from spirv-tools/source/opt/optimizer.cpp:28:
warning: In file included from spirv-tools/source/opt/passes.h:73:
warning: spirv-tools/source/opt/scalar_replacement_pass.h:42:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
warning: sprintf(&name_[strlen(name_)], "%d", max_num_elements_);
warning: ^
warning: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
warning: __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
warning: ^
warning: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
warning: #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
warning:
```
|
let's do a new patch release after this is merged, as this s blocking compilation on Mac when one have latest stuffs installed which likely more in our team will run into |
repi
changed the title
Jake-Shadle
approved these changes
Oct 14, 2022
|
@Jake-Shadle thx! do you wanna do a patch release or should I attempt one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation started failing after what I think was some Mac Xcode or system update (new compiler likely?).
This suppress this deprecation warning that failed the build:
Also few misc fixes to make sure repo builds as been a while since we changed it.