Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize output struct in opt.cpp #9

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Initialize output struct in opt.cpp #9

merged 1 commit into from
Dec 10, 2020

Conversation

khyperia
Copy link
Contributor

fixes #8

@khyperia khyperia requested a review from Jake-Shadle December 10, 2020 14:49
Jake-Shadle
Jake-Shadle approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@mergify mergify bot merged commit b1c09b5 into main Dec 10, 2020
@mergify mergify bot deleted the opt branch December 10, 2020 16:04
This was referenced Dec 14, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spirv_tools::Optimizer gives me an "optimized" binary of len 0, regardless of which opt passes I enable.
2 participants
@khyperia @Jake-Shadle