Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: Fix and make CI faster #159

Merged
merged 2 commits into from
Oct 24, 2023
Merged

infra: Fix and make CI faster #159

merged 2 commits into from
Oct 24, 2023

Conversation

WarningImHack3r
Copy link
Member

Something I wanted to make for a while: avoid unnecessary slow steps to be run if the modifications don't concern them.

List of changes

Performance

  • Use tj-actions/changed-files to get the list of the files modified by a commit
    • Use it to conditionally skip lint checks in pre-checks (around 30s)
    • Use it to conditionally skip build, deploy & perf-check if the changes are only related to the CI (3min+)
  • Use Bun for the performance-check job as it's independent and CI-only: we can win almost 30s, as tested in Migrate to Bun #114

Other changes

  • Hopefully fix the +error.svelte pages not being used by reordering logic
  • Remove the top-file credit, too much has changed since the file creation; it's no longer relevant
  • Fix typo & remove useless id

Extensive tests & reviews have to be performed to make sure I didn't break something. Files filtering at the top of the file have to be taken into account to proofread the conditions I wrote.

@WarningImHack3r WarningImHack3r changed the title Fix and make CI faster infra: Fix and make CI faster Oct 17, 2023
@WarningImHack3r WarningImHack3r requested a review from a team as a code owner October 24, 2023 21:54
@WarningImHack3r WarningImHack3r merged commit 6fbcf96 into main Oct 24, 2023
5 checks passed
@WarningImHack3r WarningImHack3r deleted the faster-ci branch October 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants