Skip to content

Commit

Permalink
chore(wallet-mobile): Drop local notifications feature flag (#3857)
Browse files Browse the repository at this point in the history
  • Loading branch information
michaeljscript authored Mar 4, 2025
1 parent 24e7675 commit 14cf825
Show file tree
Hide file tree
Showing 5 changed files with 108 additions and 114 deletions.
2 changes: 1 addition & 1 deletion apps/wallet-mobile/src/AppNavigator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const changeNavigationBarColor = (colorScheme: 'default-dark' | 'default-light',
}

export const AppNavigator = () => {
useInitNotifications({localEnabled: features.localNotifications, pushEnabled: features.pushNotifications})
useInitNotifications({localEnabled: true, pushEnabled: features.pushNotifications})
useDeepLinkWatcher()
const strings = useStrings()
const [routeName, setRouteName] = React.useState<string>()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {SafeAreaView} from 'react-native-safe-area-context'
import {Icon} from '../../../../components/Icon'
import {Spacer} from '../../../../components/Spacer/Spacer'
import {DIALOG_BUTTONS, showConfirmationDialog} from '../../../../kernel/dialogs'
import {features} from '../../../../kernel/features'
import {confirmationMessages} from '../../../../kernel/i18n/global-messages'
import {useMetrics} from '../../../../kernel/metrics/metricsManager'
import {SettingsRouteNavigation, useWalletNavigation} from '../../../../kernel/navigation'
Expand Down Expand Up @@ -137,17 +136,13 @@ export const WalletSettingsScreen = () => {

<Spacer height={24} />

{features.localNotifications && (
<>
<SettingsSection title={strings.inAppNotifications}>
<SettingsItem icon={<Icon.Bell {...iconProps} />} label={strings.allowNotifications}>
<NotificationDisplaySwitcher />
</SettingsItem>
</SettingsSection>

<Spacer height={24} />
</>
)}
<SettingsSection title={strings.inAppNotifications}>
<SettingsItem icon={<Icon.Bell {...iconProps} />} label={strings.allowNotifications}>
<NotificationDisplaySwitcher />
</SettingsItem>
</SettingsSection>

<Spacer height={24} />

<SettingsSection title={strings.about}>
<SettingsBuildItem label={strings.walletType} value={intl.formatMessage(getWalletType(implementation))} />
Expand Down
1 change: 0 additions & 1 deletion apps/wallet-mobile/src/kernel/features.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export const features = {
prefillWalletInfo: false,
showProdPoolsInDev: isDev,
moderatingNftsEnabled: false,
localNotifications: true,
pushNotifications: isDev,
poolTransition: true,
portfolioPerformance: false,
Expand Down
16 changes: 8 additions & 8 deletions apps/wallet-mobile/translations/messages/src/AppNavigator.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
"start": {
"line": 261,
"column": 17,
"index": 9836
"index": 9813
},
"end": {
"line": 264,
"column": 3,
"index": 9926
"index": 9903
}
},
{
Expand All @@ -21,12 +21,12 @@
"start": {
"line": 265,
"column": 18,
"index": 9946
"index": 9923
},
"end": {
"line": 268,
"column": 3,
"index": 10044
"index": 10021
}
},
{
Expand All @@ -36,12 +36,12 @@
"start": {
"line": 269,
"column": 25,
"index": 10071
"index": 10048
},
"end": {
"line": 272,
"column": 3,
"index": 10185
"index": 10162
}
},
{
Expand All @@ -51,12 +51,12 @@
"start": {
"line": 273,
"column": 27,
"index": 10214
"index": 10191
},
"end": {
"line": 276,
"column": 3,
"index": 10335
"index": 10312
}
}
]
Loading

0 comments on commit 14cf825

Please sign in to comment.