Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: swap refactor (#3731) #3799

Open
wants to merge 95 commits into
base: develop
Choose a base branch
from
Open

chore: swap refactor (#3731) #3799

wants to merge 95 commits into from

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Jan 27, 2025

Description / Change(s) / Related issue(s)

Work in progress, don't commit to it

  • Dexhunter Sign endpoint
  • First full run attempt
  • Product changes to adapt to multiple aggregators, specially but not limited to Splits (multiple trades instead of only a single 1)
  • Add 100% tests coverage

Co-authored-by: Juliano Lazzarotto <[email protected]>
@stackchain stackchain marked this pull request as ready for review January 27, 2025 11:57
import {PRICE_IMPACT_HIGH_RISK, PRICE_IMPACT_MODERATE_RISK} from './constants'
import {SwapPriceImpactRisk} from './types'

/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Chore: implement the update for it


const swapForm = useSwap()

const dex = swapForm.estimate?.splits[0]?.dex
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix: update according to product design (in-progress)

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 12.63736% with 795 lines in your changes missing coverage. Please review.

Project coverage is 21.94%. Comparing base (575857b) to head (181f594).

❌ Your project check has failed because the head coverage (21.94%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3799      +/-   ##
===========================================
- Coverage    22.80%   21.94%   -0.87%     
===========================================
  Files         1151     1104      -47     
  Lines        21988    21091     -897     
  Branches      3390     3288     -102     
===========================================
- Hits          5015     4628     -387     
+ Misses       16828    16305     -523     
- Partials       145      158      +13     
Components Coverage Δ
@yoroi/api 100.00% <ø> (ø)
@yoroi/blockchains 100.00% <ø> (ø)
@yoroi/claim 100.00% <ø> (ø)
@yoroi/common 100.00% <100.00%> (ø)
@yoroi/dapp-connector 100.00% <ø> (ø)
@yoroi/exchange 100.00% <ø> (ø)
@yoroi/explorers 100.00% <ø> (ø)
@yoroi/identicon 100.00% <ø> (ø)
@yoroi/links 100.00% <ø> (ø)
@yoroi/notifications 100.00% <ø> (ø)
@yoroi/portfolio 100.00% <100.00%> (ø)
@yoroi/resolver 100.00% <ø> (ø)
@yoroi/setup-wallet 100.00% <ø> (ø)
@yoroi/staking 68.82% <ø> (ø)
@yoroi/swap 62.27% <48.76%> (-37.73%) ⬇️
@yoroi/theme 100.00% <ø> (ø)
@yoroi/transfer 100.00% <ø> (ø)
@yoroi/types ∅ <ø> (∅)
@yoroi/wallet-mobile 9.77% <0.00%> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants