-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs #10
Build docs #10
Conversation
@tznind Nice! Seems like a great end to end tutorial. I will take a closer look a little bit later but for now I can say that the easiest way just to test the logic/UI is to use PoshRedisViewerHost project as it's just a console app. I guess the doc can include 2 sections: one with easy way (host) and the other the hard way (module). Usually module project is needed only for publish or when the command itself changes. Any other time host project is okay. You can even use dotnet watch with it. It will always recompile but it's quite fast at doing so. |
Ah I hadn't realized. It wasn't set as my startup project in visual studio so struggled a little. Thanks. I have updated this PR docs to indicate the two ways of testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion. Otherwise everything is perfect. Thanks!
README.md
Outdated
``` | ||
3. Start a new powershell instance (prevents stale modules sitting around etc) | ||
``` | ||
pwsh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think calling pwsh –noprofile
here is good to be sure no modules are loaded by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thats a handy flag to know about. I've added it to build instructions
PoshRedisViewer/.gitignore
Outdated
@@ -0,0 +1 @@ | |||
build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally lean to .artifacts
. Just to be more consistent with dotnet/core#8135 (comment)
But this is just gitignore and if you're accustomized to "build" then it's okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed from -o build
to -o .artifacts
and updated subsequent steps and git ignore file.
Thanks! |
Hi @En3Tho, this is my personal account. I've been getting ready to tackle #9 but first I needed to work out how to build/test the module.
These are the instructions I created. Let me know if there is a far easier way to do that and I can update them.