Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): model is not reflecting value changes when using ngModel in Angular #1051

Merged
merged 2 commits into from
May 15, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR solves the issue where ngModel is not updated properly when the Slider value changes in an Angular project. It also fixes the layout issues for when the parent container has text alignment.

Related Issue

Fixes #1050, #1049

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label May 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr linked an issue May 15, 2024 that may be closed by this pull request
@dgonzalezr dgonzalezr merged commit 73f5f32 into main May 15, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/slider-angular branch May 15, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
3 participants