Feature/toast component new #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `libs/bee-q` path to the output array of the build to be taking into account by Nx cache
Remove unnecessary dependsOn.
This method offers a convenient API and type safety to set attributes. Is primarily used to set multiple attributes at once.
…Endava#91) Docs updated for Angular output target (@bee-q/angular package)
Co-authored-by: Dabiel González Ramos <[email protected]>
Icon SVGs used under the hood on the icon components come from the Phosphor icon library, which now has moved the SVG assets to a core package: https://github.com/phosphor-icons/core. Details: https://github.com/phosphor-icons/web/releases/tag/v2.0.0
Bumps [rimraf](https://github.com/isaacs/rimraf) from 4.1.2 to 4.3.0. - [Release notes](https://github.com/isaacs/rimraf/releases) - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v4.1.2...v4.3.0) --- updated-dependencies: - dependency-name: rimraf dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.14.1 to 18.14.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…feature/toast-component-new
| // Requires JSDocs for public API documentation. | ||
| // =============================================== | ||
|
|
||
| /** Trigers function to show toast */ |
There was a problem hiding this comment.
Suggested change
| /** Trigers function to show toast */ | |
| /** Triggers function to show toast */ |
| // render() function | ||
| // Always the last one in the class. | ||
| // =================================== | ||
| private getColorAndIcon = () => { |
There was a problem hiding this comment.
Please move this one between
// Local methods
// Internal business logic.
// These methods cannot be called from the host element.
// =======================================================
// render() function
// Always the last one in the class.
// ===================================
| private getColorAndIcon = () => { | ||
| const type = this.type; | ||
| const textColor = this.textColor; | ||
| const defaultColors = { |
There was a problem hiding this comment.
It can be split into two functions
private getColorAndIcon = () => {
private get iconColor(){}
private get icon(){}
this way you can just call it directly as property even though is computed this.iconColor
|
|
||
| /** Trigers function to show toast */ | ||
| @Method() | ||
| async showToast() { |
There was a problem hiding this comment.
We should provide a method to hide toast if the user doesn't want it to autoclose.
|
|
||
| // Prop lifecycle events | ||
| // ======================= | ||
| @Watch('type') |
There was a problem hiding this comment.
make sure the timer is always >=0
if(this.autoCloseTime<0){
this.autoCloseTime = Math.max(0, this. autoCloseTime);
}
Suggested change
| @Watch('type') | |
| @Watch('type') | |
| @Watch('autoCloseTime') |
| /** Should show icon of Toast */ | ||
| @Prop({ reflect: true }) showIcon = false; | ||
| /** Should hide Toast after period of time */ | ||
| @Prop({ reflect: true }) autoCloseTime: number; |
There was a problem hiding this comment.
I would make this property accept a null as well and default it to 5000ms if null is provided it will stay open until hide method is called
| @Method() | ||
| async showToast() { | ||
| this.shouldShowToast = true; | ||
| const timeout = !this.autoCloseTime ? 5000 : this.autoCloseTime; |
There was a problem hiding this comment.
We need the timeout as property. Maybe check the usage of debounce util, I think we can leverage that to auto close the toaster. Also it provides a cancel that can be called if the user decides to close it faster.
|
I would add |
dgonzalezr
added
feature 🛠
|
Close in favour of #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(toast): add new toast component