fix(Assets): set SVG base path in the window object to keep persistence #1218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the latest changes with the asset paths require projects to set the base path regardless of whether they use the default location. With this PR, if the base path has not been set and there's no BEEQ script added to the HTML, we will set the assets path to the default location:
/svg
and avoid projects doing so on their end. This time we are also setting the value in the window object to keep persistence since using a global variable is flaky when protect sets the base path but it is not taken into account when BqIcon callsgetBasePath()
.Related Issue
Fixes #ISSUE_NUMBER
Documentation
Screenshots (if applicable)
Checklist
Additional Notes