-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Switch): enable support for form-associated #1368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cata1989
previously approved these changes
Dec 10, 2024
Cata1989
previously approved these changes
Dec 11, 2024
Cata1989
approved these changes
Dec 11, 2024
Quality Gate passedIssues Measures |
@@ -150,6 +173,20 @@ export class BqSwitch { | |||
} | |||
} | |||
|
|||
formAssociatedCallback() { | |||
console.log('formAssociatedCallback...'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
console.log('formAssociatedCallback...'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables support for form-associated custom elements, allowing them to participate in HTML forms:
https://stenciljs.com/docs/forms#using-form-associated-custom-elements
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/attachInternals
To attach the component to a form, users need to do so manually. With this PR, users only need to be aware of setting the component name attribute/property to be linked to the form.
Related Issue
N/A
Documentation
Screenshots (if applicable)
CleanShot.2024-12-10.at.14.44.08.mp4
Checklist
Additional Notes