Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix conflicting peer dependency after installing vite v6 #1407

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Jan 10, 2025

Description

This PR fixes the conflicting peer dependency warnings that are shown on npm ci after updating Vite to v6.

Related Issue

N/A

Documentation

Screenshots (if applicable)

CleanShot 2025-01-10 at 20 12 42

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added chore ⚙️ Things related to chore functionalities (types, build, ci/cd, lint, etc.) dependencies 📦 Pull requests that update a dependency file labels Jan 10, 2025
Copy link

nx-cloud bot commented Jan 10, 2025

View your CI Pipeline Execution ↗ for commit aa22f29.

Command Status Duration Result
nx run beeq:storybook-build --output-style=stream ✅ Succeeded 24s View ↗
nx affected -t e2e --exclude=*,!tag:core --para... ✅ Succeeded 1m 52s View ↗
nx affected -t build --exclude=*,!tag:publishab... ✅ Succeeded 2m 10s View ↗
nx affected -t test --exclude=*,!tag:core --par... ✅ Succeeded 21s View ↗
nx affected -t lint --exclude=*,!tag:publishabl... ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-10 18:24:25 UTC

@dgonzalezr dgonzalezr merged commit f8bfdef into main Jan 10, 2025
5 of 7 checks passed
@dgonzalezr dgonzalezr deleted the chore/deps branch January 10, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ⚙️ Things related to chore functionalities (types, build, ci/cd, lint, etc.) dependencies 📦 Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant