Skip to content
This repository has been archived by the owner on Oct 2, 2022. It is now read-only.

Add typescript peer dependency #133

Closed
wants to merge 2 commits into from
Closed

Add typescript peer dependency #133

wants to merge 2 commits into from

Conversation

kiancross
Copy link

@kiancross kiancross commented Jan 14, 2021

What did you implement:

typescript is a peer dependency of ts-node. Therefore it needs to be provided by this package; I have added it as a peer dependency.

How did you implement it:

See above.

How can we verify it:

  • See that typescript it is a peer dependency of ts-node here.
  • View package.json to see the change

Tasks:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

typescript is a peer dependency of ts-node and should therefore be
a peer dependency of this package.
@hassankhan
Copy link
Collaborator

Hi @kiancross, apologies I've only just had my commit privileges restored and realised that Travis CI doesn't work any more; going to need to switch over to GitHub Actions before the Ci can release a new version. I've created a new issue for that: #185

@kiancross
Copy link
Author

@hassankhan No problem - thanks for the update.

@beautyfree
Copy link

It's still actual for users of yarn 2+

@xboy2012
Copy link

xboy2012 commented Dec 9, 2021

Why the PR is blocked here? Please review and approve it. @hassankhan

@simPod
Copy link

simPod commented Sep 2, 2022

I believe this lib is abandoned.

@kiancross kiancross closed this by deleting the head repository Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants