This repository has been archived by the owner on Oct 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
I came across this issue which is blocking my usage of craco which now depends on cosmiconfig. I read that the PR won't be accepted until the travis-ci porting to Github Actions was completed, so this serves as a foundation to complete that.
How did you implement it:
I read the original travis-ci config and ported it to three workflows which separates the concerns:
build
lint
test
test
build
semantic-release
How can we verify it:
Check the workflow runs, these can be re-run until things work.
Secrets need to be added for:
SLACK_WEBHOOK
(if you plan on using it, otherwise can just remove this).CC_TEST_REPORTER_ID
for code climate coverage.GITHUB_TOKEN
NPM_TOKEN
Releasing will be tricky to test with it being automatic and run on master only, due to the nature of secrets and such, I can't assist here (but would if I could).
Let me know what you think, and what you would like to change, I'm happy to try and facilitate these changes where I can.
Tasks:
Write testsWrite documentationFix linting errorsMake sure code coverage hasn't droppedIs this ready for review?: YES
Is it a breaking change?: NO