Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internship] Binary Input Example #363

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NicolasHuertas
Copy link
Collaborator

Binary Input Example

The goal of this example project is to test the performance of Engflow's remote execution and caching service based on the number of input binary files in the dependency graph. The project contains a genrule that generates a specified number of Java binaries for the genbinary Java library, which are then listed as dependencies in the main binary. The Main.java file loops through each generated class and calls its greetNum method.

How It Works

  1. Generation of Java Binaries:

    • The genrule in the BUILD file generates a specified number of Java classes (Hello1.java, Hello2.java, ..., HelloN.java).
    • Each generated class contains a greetNum method that prints a unique message.
  2. Main Class Execution:

    • The Main.java file in binaryinput dynamically loads each generated class using reflection.
    • It then invokes the greetNum method of each class, printing the corresponding message.

@anfelbar
Copy link
Collaborator

@NicolasHuertas we have fixed the issue with CI. Please, sync your branches with main.

@anfelbar
Copy link
Collaborator

Thank you @NicolasHuertas for the changes. This is looking really good. Let's do a final change before acceptance.
Please, remove the python script leaving only the example. The script can be a second contribution, we will see. Remove references to the script too.

Copy link
Collaborator

@anfelbar anfelbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's wait for approval of @lfpino before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants