Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black, pylint and mypy suggestions #53

Merged
merged 7 commits into from
May 7, 2024
Merged

Apply black, pylint and mypy suggestions #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3544f9
run black over src/python/ensembl
JAlvarezJarreta May 7, 2024
bdfe4e3
run black on src/python/tests
JAlvarezJarreta May 7, 2024
6dcbec6
fix pylint issues for src/python/ensembl
JAlvarezJarreta May 7, 2024
f49b9dc
fix mypy issues for src/python/ensembl
JAlvarezJarreta May 7, 2024
5da6a31
remove codecov - run by GitLab CI/CD
JAlvarezJarreta May 7, 2024
c68d996
most users cannot create branches in ensembl-py
JAlvarezJarreta May 7, 2024
2d57970
bugfix: wrong paths in pyproject.toml
JAlvarezJarreta May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .codecov.yml
View file
Open in desktop

This file was deleted.

9 changes: 4 additions & 5 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
workflow:
rules:
- if: $CI_EXTERNAL_PULL_REQUEST_IID &&
$CI_EXTERNAL_PULL_REQUEST_SOURCE_REPOSITORY == $CI_EXTERNAL_PULL_REQUEST_TARGET_REPOSITORY &&
$CI_EXTERNAL_PULL_REQUEST_TARGET_BRANCH_NAME == $CI_DEFAULT_BRANCH
- if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH

Expand Down Expand Up @@ -81,12 +80,12 @@ python:prepare_venv:
python:pylint:src:
extends: .python:pylint
script:
- $PYLINT_CMD src
- $PYLINT_CMD src/python/ensembl

python:pylint:tests:
extends: .python:pylint
script:
- $PYLINT_CMD tests
- $PYLINT_CMD --recursive=y src/python/tests

### mypy
.python:mypy:
Expand All @@ -97,13 +96,13 @@ python:pylint:tests:
python:mypy:src:
extends: .python:mypy
script:
- $MYPY_CMD src
- $MYPY_CMD src/python/ensembl

python:mypy:tests:
extends: .python:mypy
allow_failure: true
script:
- $MYPY_CMD tests
- $MYPY_CMD src/python/tests

### black
python:black:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ disable = [
]

[tool.mypy]
mypy_path = "src"
mypy_path = "src/python/ensembl"
explicit_package_bases = true
ignore_missing_imports = true
show_error_codes = true
Expand Down
Loading