Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: add alternatives to fixture or raise exception #68

Merged
merged 3 commits into from
May 9, 2024
Merged

Bugfix: add alternatives to fixture or raise exception #68

merged 3 commits into from
May 9, 2024

Conversation

JAlvarezJarreta
Copy link
Collaborator

No description provided.

@JAlvarezJarreta JAlvarezJarreta added the bug Something isn't working label May 9, 2024
@JAlvarezJarreta JAlvarezJarreta self-assigned this May 9, 2024
@JAlvarezJarreta JAlvarezJarreta mentioned this pull request May 9, 2024
Merged
ens-LCampbell
ens-LCampbell approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@ens-LCampbell ens-LCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should suffice thank you Jorge ! I wasn't sure what the issue was to be honest given the current structure of the dirs

@MatBarba
Copy link
Contributor

MatBarba commented May 9, 2024

Based on https://docs.pytest.org/en/latest/explanation/goodpractices.html we also need to support the tests folder at the root of the repo (we use that in one of our other repos)

@JAlvarezJarreta JAlvarezJarreta merged commit 855828a into main May 9, 2024
1 check passed
@JAlvarezJarreta JAlvarezJarreta deleted the jalvarez/bugfix branch May 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ens-LCampbell ens-LCampbell ens-LCampbell approved these changes

@MatBarba MatBarba Awaiting requested review from MatBarba

Assignees

@JAlvarezJarreta JAlvarezJarreta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAlvarezJarreta @MatBarba @ens-LCampbell