Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require type hints in all methods and functions #81

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Require type hints in all methods and functions #81

merged 3 commits into from
Sep 10, 2024

Conversation

JAlvarezJarreta
Copy link
Collaborator

Following the same idea as Ensembl/ensembl-utils#23

@JAlvarezJarreta JAlvarezJarreta added the enhancement New feature or request label Sep 5, 2024
@JAlvarezJarreta JAlvarezJarreta self-assigned this Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
core
   __init__.py00100% 
   models.py7900100% 
ncbi_taxonomy
   __init__.py00100% 
   models.py270100% 
ncbi_taxonomy/api
   __init__.py10100% 
   utils.py87297%149, 231
xrefs
   xref_source_db_model.py280100% 
   xref_update_db_model.py1960100% 
TOTAL1129299% 

Tests Skipped Failures Errors Time
26 0 💤 0 ❌ 0 🔥 1.282s ⏱️

MatBarba
MatBarba approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@MatBarba MatBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, though I get a pytest error (not related to this PR, see #82).

Dishalodha
Dishalodha approved these changes Sep 10, 2024
View reviewed changes
Copy link

@Dishalodha Dishalodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JAlvarezJarreta JAlvarezJarreta merged commit 6961219 into main Sep 10, 2024
5 checks passed
@JAlvarezJarreta JAlvarezJarreta deleted the jalvarez/improve_typing branch September 10, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatBarba MatBarba MatBarba approved these changes

@Dishalodha Dishalodha Dishalodha approved these changes

Assignees

@JAlvarezJarreta JAlvarezJarreta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAlvarezJarreta @MatBarba @Dishalodha