Merge pull request #895 from Enterprise-CMCS/main

Release to val

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,30 @@
-## Purpose
+<!--
+TODO for PR Author:
+- Would your work benefit from unit tests?
+- Have you formatted your files using Prettier/ESLint?
+- Delete any irrelevant sections below before opening the pull request
+- title your PR using the angular commit convention -> https://www.conventionalcommits.org/en/v1.0.0/
+  type-of-changes(scope-in-codebase): distilled description of changes
+  e.g. feat/fix/test(ui/api/lib): refactor Hello World console log
+-->
 
-_Describe the problem or feature in addition to a link to the issues._
+## 🎫 Linked Ticket
 
-#### Linked Issues to Close
+<!-- Link to the JIRA ticket to track this work -->
 
-_Links to issue(s) that are closed by this PR. Be sure to use the phrase "Closes #XXX" for each issue, so they automatically close_
+[Ticket to close](link-to-ticket)
 
-## Approach
+## 💬 Description / Notes
 
-_How does this change address the issue?_
+<!-- Briefly describe the background of the issue -->
+<!-- If you feel the original ticket lacks important details, this would be the place to share them -->
 
-## Assorted Notes/Considerations/Learning
+## 🛠 Changes
 
-_List any other information that you think is important... a post-merge activity, someone to notify, what you learned, etc._
+<!-- List your code changes made to implement the solution -->
+
+## 📸 Screenshots / Demo
+
+<!-- ### Before -->
+
+<!-- ### After -->

.github/workflows/deploy.yml

@@ -130,7 +130,6 @@ jobs:
           coverageLocations: coverage/lcov.info:lcov
 
   e2e:
-    timeout-minutes: 5
     runs-on: ubuntu-20.04
     needs:
       - deploy
@@ -148,8 +147,6 @@ jobs:
           role-to-assume: ${{ secrets.AWS_OIDC_ROLE_TO_ASSUME }}
           aws-region: us-east-1
           role-duration-seconds: 10800
-      - name: Install Playwright with Chrome
-        run: npx playwright install --with-deps chromium
       - name: Run e2e tests
         run: run e2e
       - uses: actions/upload-artifact@v3

bin/cli/src/commands/e2e.ts

@@ -12,8 +12,9 @@ export const e2e = {
     }),
   handler: async ({ ui }: { ui: boolean }) => {
     await checkIfAuthenticated();
-    await runCommand("bun", ["playwright", "install", "--with-deps"], ".");
+    console.log(ui);
+    await runCommand("bun", ["playwright", "install", "--with-deps", "chromium"], ".");
 
-    await runCommand("bun", [ui ? "e2e:ui" : "e2e"], ".");
+    await runCommand("bun", [ui ? "e2e:ui" : "e2e", "--", "--", "--grep", "@CI"], ".");
   },
 };

bin/cli/src/commands/logs.ts

@@ -127,7 +127,7 @@ async function getLambdasWithTags(tags: Tag[]): Promise<string[]> {
           const functionData = await lambdaClient.send(functionCommand);
           return functionData.Configuration?.FunctionName || "";
         } catch {
-          console.log(`Ecluding function ${arn}.`);
+          console.log(`Excluding function ${arn}.`);
           return "";
         }
       }),