feat(test) Unit test for updating pacakges #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test-app
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test-kibana
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
commented
Jan 10, 2025
| @@ -35,7 +37,7 @@ const items: Record<string, TestItemResult> = { | |||
| actionType: "New", | |||
| }, | |||
| }, | |||
| ["VA"]: { | |||
| [WEIRD_ID]: { | |||
There was a problem hiding this comment.
There is a certain check that wants to make sure an ID is just a wrong format for an item but it exist with in our system hence "weird"
thetif
reviewed
Jan 10, 2025
| const resultPackage = await handler(noActionevent); | ||
|
|
||
| expect(resultPackage.statusCode).toBe(400); | ||
| const noApackageEvent = { |
There was a problem hiding this comment.
you should probably split these into two tests just for clarity
| @@ -102,7 +102,7 @@ const sendUpdateIdMessage = async ({ | |||
| ...remainingFields | |||
| } = currentPackage._source; | |||
|
|
|||
| if (!updatedId) { | |||
| if (updatedId === currentPackage._id) { | |||
There was a problem hiding this comment.
should this be if (!updatedId || updatedId === currentPackage._id) {?
There was a problem hiding this comment.
Its impossible for updatedId to not exist. Its set to default to packageId if one is not provided on line 192.
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thwalker6
temporarily deployed
to
update-packages-test
GitHub Actions
Inactive
thetif
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
Ticket to close
💬 Description / Notes
Adding unit test coverage for the update lambda
🛠 Changes
Removed some unhittable exceptions we were doing. Since the zod object was verifying fields there was just a couple things not matter what you couldn't hit.
I also refactored some code by moving it around a little to make sure we are returning the values we want to in some cases.
📸 Screenshots / Demo