fix(setupIndex): fix case where index already exists #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he index exists... will need to reindex in that case
13bfrancis
approved these changes
Nov 28, 2023
benjaminpaige
approved these changes
Nov 28, 2023
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This changeset fixes a bug seen during re-deployment of existing environments with the new setupIndex code.
Linked Issues to Close
Bug against RAI Issue / Withdraw
Approach
While we were guarding against attempting to create the index if it already exists, we were not guarding against attempting to update the field mapping if one already existed. This is an edge case, and is handled with a reindex, so we will stick the 'update field mapping' inside the 'if exists' guard.
Assorted Notes/Considerations/Learning
None