Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(status memo): Write onemac activity to the Status Memo field #352

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

mdial89f
Copy link
Contributor

@mdial89f mdial89f commented Feb 1, 2024

Purpose

This adds functionality to new submission and all package actions to write a log entry of what happened to Status Memo.

Linked Issues to Close

None
Helps enable https://qmacbis.atlassian.net/browse/OY2-26753

Approach

CMS sometimes uses the Status_Memo field in Seatool's State Plan table to keep a log of what updates people make to a state plan submission. We've been told specifically that when a medicaid RAI is withdrawn, we want to save the submission and withdrawn dates in the Status Memo, as the RAI data could eventually be overwritten.

In light of the RAi withdraw behavior that needs to write to Status Memo, and considering our broader capabilities, I think it's wise to write a log entry of the action taken by the OneMAC system against a record any time that record is modified.

So, in this PR, the submission action and all package actions that modify seatool records are updated. They're updated to send an additional query to add a new text entry to Status Memo.

Status Memo is modified from the top (newest on top), so the new text is appended to the beginning and ends with a newline.

Here's what Status Memo looks like for a test record where I've stepped through all actions:
Screen Shot 2024-02-01 at 6 59 06 AM

  • we're starting each message with a hyphen
  • after the hyphen we specify OneMAC Activity, followed by a timestamp
  • finally, the action being taken is listed.

I made a helper function to keep the query for each action consistent. I expect this will be refactored with the backend refactor, so I didn't stress to much about style. I did, however, make the choice of passing the message text as a function parameter, instead of passing just the action type. I like the flexibility of writing anything we want, and not being constrained to the action name.

Assorted Notes/Considerations/Learning

  • This enables the RAI withdraw ticket.

@mdial89f mdial89f requested a review from pkim-gswell February 1, 2024 12:06
@mdial89f mdial89f added type: FEAT Submit new features status: READY PR is ready for review labels Feb 1, 2024
@mdial89f mdial89f self-assigned this Feb 1, 2024
Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, id love to see a demo

Copy link
Contributor

@pkim-gswell pkim-gswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent and thorough summary of the work.

iapprove

@mdial89f mdial89f merged commit e0c9db0 into master Feb 1, 2024
16 checks passed
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @val status: READY PR is ready for review type: FEAT Submit new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants