Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cs3): Add Cs3 to our webforms list #707

Merged
merged 11 commits into from
Aug 13, 2024
Merged

feat(cs3): Add Cs3 to our webforms list #707

merged 11 commits into from
Aug 13, 2024

Conversation

jdinh8124
Copy link
Collaborator

@jdinh8124 jdinh8124 commented Aug 6, 2024

Purpose

Add CS3 to our webforms list. Testing will commence after PR approval from webforms team. Also added logic to sort string numbers.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-28504

@jdinh8124 jdinh8124 added type: FEAT Submit new features status: READY PR is ready for review labels Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.74% 4251 / 7909
🔵 Statements 53.6% 4475 / 8348
🔵 Functions 48.24% 1017 / 2108
🔵 Branches 27.05% 803 / 2968
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
react-app/src/components/RHF/FieldArray.tsx 100% 100% 100% 100%
react-app/src/components/RHF/SlotField.tsx 85.71% 75% 75% 91.66% 94-96, 187
react-app/src/components/RHF/utils/additionalRules.ts 75% 83.33% 62.5% 74.28% 7-8, 15-16, 18-22, 19, 21, 53, 83
Generated in workflow #67

Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit 618beec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.7% (0.0% change).

View more on Code Climate.

@jdinh8124 jdinh8124 merged commit d8a8a24 into main Aug 13, 2024
16 checks passed
@jdinh8124 jdinh8124 deleted the cs3 branch August 13, 2024 16:45
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.72 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @val status: READY PR is ready for review type: FEAT Submit new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants