-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): adding new mocks strategy to tests #880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetif
had a problem deploying
to
mocking-tests
December 2, 2024 23:22 — with
GitHub Actions
Failure
thetif
had a problem deploying
to
mocking-tests
December 3, 2024 14:21 — with
GitHub Actions
Failure
thetif
had a problem deploying
to
mocking-tests
December 3, 2024 23:39 — with
GitHub Actions
Failure
thetif
temporarily deployed
to
mocking-tests-kibana
December 3, 2024 23:39 — with
GitHub Actions
Inactive
thetif
temporarily deployed
to
mocking-tests-app
December 3, 2024 23:39 — with
GitHub Actions
Inactive
thetif
temporarily deployed
to
mocking-tests-kibana
December 4, 2024 17:15 — with
GitHub Actions
Inactive
thetif
temporarily deployed
to
mocking-tests-app
December 4, 2024 17:15 — with
GitHub Actions
Inactive
asharonbaltazar
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the greater good 🫡
thetif
had a problem deploying
to
mocking-tests
December 9, 2024 18:18 — with
GitHub Actions
Failure
thetif
temporarily deployed
to
mocking-tests-app
December 9, 2024 18:18 — with
GitHub Actions
Inactive
thetif
temporarily deployed
to
mocking-tests-kibana
December 9, 2024 18:18 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 15:15 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 15:15 — with
GitHub Actions
Inactive
13bfrancis
had a problem deploying
to
mocking-tests
December 10, 2024 15:17 — with
GitHub Actions
Failure
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 15:17 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests-app
December 10, 2024 15:17 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests-kibana
December 10, 2024 15:17 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 15:17 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 16:08 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 16:08 — with
GitHub Actions
Inactive
13bfrancis
had a problem deploying
to
mocking-tests
December 10, 2024 16:10 — with
GitHub Actions
Failure
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 16:10 — with
GitHub Actions
Inactive
13bfrancis
temporarily deployed
to
mocking-tests
December 10, 2024 16:10 — with
GitHub Actions
Inactive
Please don't forget to delete your branch after merging, thanks! |
🎉 This PR is included in version 1.5.0-val.98 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replacing the adhoc mocking of the api calls with mock service worker. Created mocks for
/item
,/itemExists
,/getUploadUrl
,/submit
,/test
, andhttps://api.census.gov/data/2019/pep/population?get=NAME&for=county:*&in=state:${stateString}
Linked Issues to Close
https://jiraent.cms.gov/browse/OY2-31031
Approach
Removed need for redundant mocking for each test. Should speed up writing tests and make the test data more robust.
Assorted Notes/Considerations/Learning