Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): refactor sinkMain and create tests #897

Merged
merged 49 commits into from
Dec 16, 2024

Conversation

asharonbaltazar
Copy link
Collaborator

Purpose

Improve sinkMain logic and write tests

Linked Issues to Close

https://jiraent.cms.gov/browse/OY2-31425

Approach

  • break out functionality into smaller pieces
  • rename functions and variables to better convey processes

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 73.93% 5984 / 8094
🔵 Statements 73.2% 6310 / 8620
🔵 Functions 67.23% 1773 / 2637
🔵 Branches 40.43% 1091 / 2698
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/sinkChangelog.ts 0% 0% 0% 0% 9-98
lib/lambda/sinkCpocs.ts 33.33% 12.5% 50% 33.33% 17-18, 28-73
lib/lambda/sinkInsights.ts 0% 0% 0% 0% 6-44
lib/lambda/sinkLegacyInsights.ts 0% 0% 0% 0% 6-61
lib/lambda/sinkMain.test.ts 100% 100% 100% 100%
lib/lambda/sinkMain.ts 100% 100% 100% 100%
lib/lambda/sinkMainProcessors.test.ts 100% 100% 100% 100%
lib/lambda/sinkMainProcessors.ts 100% 97.14% 100% 100%
lib/lambda/sinkSubtypes.ts 0% 0% 0% 0% 6-55
lib/lambda/sinkTypes.ts 0% 0% 0% 0% 6-55
lib/libs/opensearch-lib.ts 0% 0% 0% 0% 15-283
lib/libs/sink-lib.test.ts 100% 100% 100% 100%
lib/libs/sink-lib.ts 100% 90.47% 100% 100%
lib/packages/shared-types/opensearch/main/transforms/changedDate.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/seatool.ts 76.81% 62.03% 75.86% 80.35% 46-55, 59, 62, 65, 109, 47-55, 109
lib/packages/shared-types/seatool-tables/State_Plan.ts 100% 100% 100% 100%
lib/packages/shared-utils/decode.ts 100% 100% 50% 100%
react-app/src/features/package/package-details/appk.tsx 4.34% 0% 0% 4.34% 13-93
Generated in workflow #1071 for commit 5ee0bf0 by the Vitest Coverage Report Action

@asharonbaltazar asharonbaltazar merged commit 6b5b588 into main Dec 16, 2024
15 checks passed
@asharonbaltazar asharonbaltazar deleted the refactor-tests-sink branch December 16, 2024 21:41
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.98 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants