feat(workspace): update PR template #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
daniel-belcher
approved these changes
Dec 5, 2024
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template-kibana
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template-app
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
|
I like it,especially the screenshot part, i always enjoy a good screenshot in a pr. also even just some 'polite' reminders would be good. are all the tests passing? if you removed any code did you remove anything related to that code we no longer need? i dont kow something like that. even maybe..... "did you run this new code through a llm to see if there is anyway it could be improved? Are all types complete and correct? i know i am more guilty than most of these atrocities.... but that still doesn't mean it wouldn't be good to include them. lol anyways, i like it. keep it simple, but relevent. 👍 |
benjaminpaige
approved these changes
Dec 6, 2024
tbolt
approved these changes
Dec 6, 2024
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
improve-pr-template
GitHub Actions
Inactive
|
🎉 This PR is included in version 1.5.0-val.98 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I'm tired of the old PR template, so I've decided to renew it