Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Appendix K design updates #902

Merged
merged 11 commits into from
Dec 11, 2024
Merged

feat(ui): Appendix K design updates #902

merged 11 commits into from
Dec 11, 2024

Conversation

tbolt
Copy link
Collaborator

@tbolt tbolt commented Dec 6, 2024 •
edited
Loading

Purpose

This PR addresses design discrepancies with the Appendix K form including:

  • Adjusting the Amendment Title input box to match size in Figma
  • Updating casing on "What is my Waiver Amendment Number?" link
  • Updates to the Attachments section
    • Language change: Appendix K Template -> 1915(c) Appendix K Amendment Waiver Template
    • Updates hint on 1915(c) Appendix K Amendment Waiver Template file input to be At least one attachment is required
    • Adding multiple files to 1915(c) Appendix K Amendment Waiver Template no longer triggers an error
    • Makes the Other file input to be optional

Linked Issues to Close

Closes OY2-31071

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.97% 5822 / 8089
🔵 Statements 71.32% 6147 / 8618
🔵 Functions 66.24% 1739 / 2625
🔵 Branches 38.53% 1061 / 2753
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/packages/shared-types/events/app-k.ts 100% 100% 100% 100%
react-app/src/features/forms/waiver/app-k/index.test.tsx 100% 100% 100% 100%
react-app/src/features/forms/waiver/app-k/index.tsx 80% 66.66% 75% 80% 126
Generated in workflow #933 for commit 01c617c by the Vitest Coverage Report Action

@tbolt tbolt temporarily deployed to app-k-design-updates December 6, 2024 18:22 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 6, 2024 18:22 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 6, 2024 18:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 6, 2024 18:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates-kibana December 6, 2024 18:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates-app December 6, 2024 18:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 6, 2024 18:23 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar changed the title App k design updates feat(ui): App K design updates Dec 6, 2024
@tbolt tbolt changed the title feat(ui): App K design updates feat(ui): Appendix K design updates Dec 6, 2024
@tbolt tbolt marked this pull request as ready for review December 6, 2024 18:38
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 15:36 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 15:36 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to app-k-design-updates December 9, 2024 15:38 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to app-k-design-updates-kibana December 9, 2024 15:38 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates-app December 9, 2024 15:38 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 15:38 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 16:04 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 16:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 16:09 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to app-k-design-updates December 9, 2024 16:11 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to app-k-design-updates-app December 9, 2024 16:11 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates-kibana December 9, 2024 16:11 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 16:11 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 16:11 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 21:07 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 21:07 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates-app December 9, 2024 21:12 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates-kibana December 9, 2024 21:12 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 21:12 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to app-k-design-updates December 9, 2024 21:12 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to app-k-design-updates December 9, 2024 21:12 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to app-k-design-updates December 10, 2024 14:33 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to app-k-design-updates December 11, 2024 15:03 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 11, 2024 15:03 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to app-k-design-updates December 11, 2024 15:09 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to app-k-design-updates December 11, 2024 15:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-design-updates December 11, 2024 15:09 — with GitHub Actions Inactive
@tbolt tbolt merged commit 5b7302f into main Dec 11, 2024
14 of 15 checks passed
@tbolt tbolt deleted the app-k-design-updates branch December 11, 2024 15:39
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.98 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

@thetif thetif Awaiting requested review from thetif

@13bfrancis 13bfrancis Awaiting requested review from 13bfrancis

@tiffanyvu tiffanyvu Awaiting requested review from tiffanyvu

@charmcitygavin charmcitygavin Awaiting requested review from charmcitygavin

Assignees
No one assigned
Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbolt @asharonbaltazar