-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): updated correct links for pdf templates for FAQ #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
RanyeM
temporarily deployed
to
update-pdf-links-kibana
December 9, 2024 21:32 — with
GitHub Actions
Inactive
RanyeM
had a problem deploying
to
update-pdf-links
December 9, 2024 21:32 — with
GitHub Actions
Failure
RanyeM
temporarily deployed
to
update-pdf-links
December 9, 2024 21:32 — with
GitHub Actions
Inactive
RanyeM
temporarily deployed
to
update-pdf-links-app
December 9, 2024 21:32 — with
GitHub Actions
Inactive
RanyeM
temporarily deployed
to
update-pdf-links
December 9, 2024 21:32 — with
GitHub Actions
Inactive
RanyeM
temporarily deployed
to
update-pdf-links
December 9, 2024 22:11 — with
GitHub Actions
Inactive
RanyeM
temporarily deployed
to
update-pdf-links
December 9, 2024 22:11 — with
GitHub Actions
Inactive
RanyeM
had a problem deploying
to
update-pdf-links
December 9, 2024 22:13 — with
GitHub Actions
Failure
RanyeM
temporarily deployed
to
update-pdf-links
December 9, 2024 22:13 — with
GitHub Actions
Inactive
RanyeM
temporarily deployed
to
update-pdf-links
December 9, 2024 22:13 — with
GitHub Actions
Inactive
RanyeM
had a problem deploying
to
update-pdf-links
December 9, 2024 22:20 — with
GitHub Actions
Failure
asharonbaltazar
changed the title
fix: updated correct links for pdf templates for FAQ
fix(ui): updated correct links for pdf templates for FAQ
Dec 10, 2024
asharonbaltazar
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 1.5.0-val.98 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
#887
https://jiraent.cms.gov/browse/OY2-29929
💬 Description / Notes
Add links to the FAQ page to the corresponding MMDL template. (reference google drive folder)
Links should be ordered and worded like in the HCD figma
When clicked, the pdf template should open in a new tab
🛠 Changes
Given I am a Mako user, When I navigate to the FAQ page, Then I should be able to click the MMDL templates and view the template in a new tab.
Dev Note: The document names use the same title as the question/header on the FAQ page. For example, if the section header is "ABP 1: Alternative Benefit Plan Populations", then document on the google drive named "IG_ABP1_AlternativeBenefitPlanPopulations.doc" should be attached to that FAQ link.
Google Folder with MMDL Templates: https://drive.google.com/drive/folders/1C7LtmhwMoqJnfqfdOKUkhbgZ6W7uSgtt?usp=drive_link
Figma (reference "Final" tab): https://www.figma.com/design/TJcaOKbbiLOaMMV3MQmczT/MMDL-PDFs-into-OneMAC?node-id=329-9126&node-type=canvas&t=SCgkJLxfLZL69cZh-0