Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unidirectional-camel-case): Make seatool non-case sensitive when writing to opensearch #958

Merged
merged 9 commits into from
Jan 10, 2025
Merged

feat(unidirectional-camel-case): Make seatool non-case sensitive when writing to opensearch #958

merged 9 commits into from
Jan 10, 2025

Conversation

rmuntaqim
Copy link
Collaborator

  • testing capitlized code
  • passing id to function
  • Setting the ID key in the object
  • removing console.log
  • updating cap function

🎫 Linked Ticket

Ticket to close

💬 Description / Notes

🛠 Changes

📸 Screenshots / Demo

@rmuntaqim rmuntaqim had a problem deploying to unidirectional-camel-case January 2, 2025 06:35 — with GitHub Actions Failure
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 2, 2025 06:35 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.54% 6557 / 8680
🔵 Statements 74.73% 6871 / 9194
🔵 Functions 69.35% 1971 / 2842
🔵 Branches 43.36% 1241 / 2862
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/packages/shared-types/opensearch/main/transforms/seatool.ts 76.81% 62.03% 75.86% 80.35% 46-55, 59, 62, 65, 109, 47-55, 109
Generated in workflow #1365 for commit 2a2c055 by the Vitest Coverage Report Action

@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 2, 2025 06:40 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 2, 2025 06:40 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case-app January 2, 2025 06:40 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case-kibana January 2, 2025 06:40 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 2, 2025 06:40 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case January 2, 2025 16:09 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case January 2, 2025 16:09 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case January 2, 2025 16:11 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case January 2, 2025 16:11 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case-kibana January 2, 2025 16:11 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case-app January 2, 2025 16:11 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to unidirectional-camel-case January 2, 2025 16:11 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case January 7, 2025 16:26 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case January 7, 2025 16:26 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case-app January 7, 2025 16:30 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case January 7, 2025 16:30 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case January 7, 2025 16:30 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case-kibana January 7, 2025 16:30 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to unidirectional-camel-case January 7, 2025 16:30 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 7, 2025 17:43 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 7, 2025 17:43 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim deployed to unidirectional-camel-case January 7, 2025 17:46 — with GitHub Actions Active
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 7, 2025 17:46 — with GitHub Actions Inactive
@rmuntaqim rmuntaqim temporarily deployed to unidirectional-camel-case January 7, 2025 17:46 — with GitHub Actions Inactive
13bfrancis
13bfrancis approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good

lib/packages/shared-types/opensearch/main/transforms/seatool.ts Outdated
Comment on lines 82 to 84
name: `${o.FIRST_NAME || ""} ${o.LAST_NAME || ""}`,
email: o.EMAIL || "",
}))
name: `${o.FIRST_NAME} ${o.LAST_NAME}`,
email: o.EMAIL,
}))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change lines 82-84 to align with what is on main. I don't think this should be different from what is on main. After that I think we are good to have this tested

@13bfrancis 13bfrancis changed the title unidirectional camel case feat(unidirectional-camel-case): Make seatool non-case sensitive when writing to opensearch Jan 10, 2025
@13bfrancis 13bfrancis merged commit 8982d92 into main Jan 10, 2025
16 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.105 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanyvu tiffanyvu tiffanyvu approved these changes

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

@13bfrancis 13bfrancis 13bfrancis approved these changes

Assignees
No one assigned
Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmuntaqim @13bfrancis @asharonbaltazar @tiffanyvu