Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock-test-s3 #975

Closed
wants to merge 0 commits into from
Closed

Mock-test-s3 #975

wants to merge 0 commits into from

Conversation

thetif
Copy link
Collaborator

@thetif thetif commented Jan 7, 2025

🎫 Linked Ticket

Ticket to close

💬 Description / Notes

🛠 Changes

📸 Screenshots / Demo

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.54% 6557 / 8680
🔵 Statements 74.73% 6871 / 9194
🔵 Functions 69.35% 1971 / 2842
🔵 Branches 43.36% 1241 / 2862
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/vitest.setup.ts 100% 100% 100% 100%
lib/lambda/cfnNotify.test.ts 100% 100% 100% 100%
lib/lambda/cfnNotify.ts 100% 100% 100% 100%
lib/lambda/checkConsumerLag.test.ts 100% 100% 100% 100%
lib/lambda/checkConsumerLag.ts 100% 94.44% 100% 100%
lib/lambda/createTriggers.test.ts 100% 100% 100% 100%
lib/lambda/createTriggers.ts 90.62% 70% 50% 93.54% 70-71
lib/lambda/deleteIndex.test.ts 100% 100% 100% 100%
lib/lambda/deleteTriggers.test.ts 100% 100% 100% 100%
lib/lambda/deleteTriggers.ts 90.32% 50% 66.66% 93.33% 52-53
lib/lambda/mapRole.test.ts 100% 100% 100% 100%
lib/lambda/mapRole.ts 90.47% 83.33% 100% 90.47% 36-37
lib/lambda/runReindex.test.ts 100% 100% 100% 100%
lib/lambda/runReindex.ts 100% 83.33% 100% 100%
lib/lambda/setupIndex.test.ts 100% 100% 100% 100%
lib/libs/sink-lib.test.ts 100% 100% 100% 100%
lib/libs/sink-lib.ts 100% 95.65% 100% 100%
Generated in workflow #1352 for commit a1eadb3 by the Vitest Coverage Report Action

benjaminpaige
benjaminpaige reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You certainly have my approval if you ever do want to merge this.

@thetif thetif closed this Jan 7, 2025
@thetif thetif deleted the mock-test-s3 branch January 7, 2025 16:38
@thetif thetif deployed to mock-test-lambda January 7, 2025 16:38 — with GitHub Actions Active
@asharonbaltazar asharonbaltazar deployed to fix-email-logo January 7, 2025 17:00 — with GitHub Actions Active
@asharonbaltazar asharonbaltazar deployed to update-package-func January 7, 2025 17:00 — with GitHub Actions Active
@asharonbaltazar asharonbaltazar deployed to redirect-login January 7, 2025 17:00 — with GitHub Actions Active
@asharonbaltazar asharonbaltazar deployed to update-snapshots January 7, 2025 17:00 — with GitHub Actions Active
@asharonbaltazar asharonbaltazar deployed to package-detail-error-redirect January 7, 2025 17:00 — with GitHub Actions Active
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq January 7, 2025 18:40 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq January 7, 2025 18:40 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq January 7, 2025 18:52 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq January 7, 2025 18:52 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq-app January 7, 2025 18:52 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq-kibana January 7, 2025 18:52 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-chip-faq January 7, 2025 18:52 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to eco-tif-kibana January 7, 2025 19:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpaige benjaminpaige benjaminpaige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thetif @benjaminpaige @asharonbaltazar @tiffanyvu