Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lamda): add admin function for NOSOs #990

Closed
wants to merge 37 commits into from
Closed

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Jan 8, 2025

❌ NOT READY ❌

🎫 Linked Ticket

OY2-31182

💬 Description / Notes

Need to add the ability for an admin to run a lamdba for NOSOs to move over to mako

Submit NOSO

  1. In lamdba functions go to mako--api-submitNOSO
  2. Click Test and JSON should be formated like:
    { "body": { "id": "MD-25-1234", "action": "submit", "adminChangeType": "submit", "attachmentsFrom": "[package-id]" }

🛠 Changes

added an admin function for creating a new submissions for NOSOs

  • move change admin functions to their own folder
  • followed similar structure used for admin updatePackage

📸 Screenshots / Demo

@andieswift andieswift self-assigned this Jan 8, 2025
@andieswift andieswift added the status: NOT READY PR ain't ready label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 81.47% 3865 / 4744
🔵 Statements 81.05% 4215 / 5200
🔵 Functions 72.43% 1122 / 1549
🔵 Branches 65% 1817 / 2795
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/sinkChangelog.ts 87.27% 87.5% 100% 88.88% 105-110, 134, 145
lib/lambda/sinkMainProcessors.ts 100% 100% 100% 100%
lib/lambda/adminActions/submitNOSO.ts 4.61% 0% 0% 4.68% 10-86, 98-122, 126-161
lib/packages/shared-types/opensearch/changelog/index.ts 100% 100% 100% 100%
react-app/src/features/package/admin-changes/index.tsx 30% 0% 0% 33.33% 54-68, 89-92
Generated in workflow #1639 for commit e71d117 by the Vitest Coverage Report Action

@andieswift
Copy link
Collaborator Author

andieswift commented Jan 24, 2025

I am doing this work here: #1060 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: NOT READY PR ain't ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant