Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test) Email handler test #998

Merged
merged 2 commits into from
Jan 9, 2025
Merged

feat(test) Email handler test #998

merged 2 commits into from
Jan 9, 2025

Conversation

thwalker6
Copy link
Collaborator

🎫 Linked Ticket

[Ticket to close](https://jiraent.cms.gov/browse/OY2-32115)

💬 Description / Notes

🛠 Changes

Added some new test that will give coverage to a bunch of our index.ts files for our emails. Improving our handler test.

📸 Screenshots / Demo

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.99% 7175 / 8859
🔵 Statements 79.96% 7490 / 9367
🔵 Functions 72.47% 2096 / 2892
🔵 Branches 49.07% 1352 / 2755
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/processEmailsHandlers.test.ts 100% 100% 100% 100%
Generated in workflow #1432 for commit 7c7eb78 by the Vitest Coverage Report Action

Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

eventSource: "",
bootstrapServers: "",
};
await handler(mockEvent, {} as Context, callback);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await handler(mockEvent, {} as Context, callback);
await handler(mockEvent, expect.anything(), callback);

Comment on lines +8 to +13
const nms = "new-medicaid-submission";
const ncs = "new-chip-submission";
const tempExtension = "temp-extension";
const withdrawPackage = "withdraw-package";
const contractingInitial = "contracting-initial";
const capitatedInitial = "capitated-initial";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we capitalize these variable names?

@thwalker6 thwalker6 merged commit d68c42e into main Jan 9, 2025
15 checks passed
@thwalker6 thwalker6 deleted the email-index-test branch January 9, 2025 20:27
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎉 This PR is included in version 1.5.0-val.103 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants