Add MIME checks to uploads avScan service (#2787)

* fix uploads tests. use vitest. * add some mime type checks btwn file and ending * add mime type check test * use actual eicar pdf file * fix clamav test * adds check for csv and txt * fix scanFile test * now we mark infected properly here
Enterprise-CMCS · Oct 8, 2024 · a19797e · a19797e
1 parent 6e4f390
commit a19797e
Show file tree

Hide file tree

Showing 38 changed files with 1,094 additions and 525 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/services/app-api/src/postgres/state/findStateAssignedUsers.ts b/services/app-api/src/postgres/state/findStateAssignedUsers.ts
@@ -4,16 +4,19 @@ import type { UserType } from '../../domain-models'
 import { NotFoundError } from '../postgresErrors'
 import { parseDomainUsersFromPrismaUsers } from '../user/prismaDomainUser'
 
-async function findStateAssignedUsers( client: PrismaTransactionType, stateCode: string):  Promise<UserType[] | Error> {
+async function findStateAssignedUsers(
+    client: PrismaTransactionType,
+    stateCode: string
+): Promise<UserType[] | Error> {
     const pilotStateCodes = statePrograms.states.map((state) => state.code)
-    if(!pilotStateCodes.includes(stateCode)) {
+    if (!pilotStateCodes.includes(stateCode)) {
         return new Error(`${stateCode} is not a supported state code`)
     }
 
     try {
         const state = await client.state.findFirst({
             where: {
-                stateCode
+                stateCode,
             },
             include: {
                 assignedCMSUsers: {
@@ -34,9 +37,7 @@ async function findStateAssignedUsers( client: PrismaTransactionType, stateCode:
             return new NotFoundError(err)
         }
 
-        const users = parseDomainUsersFromPrismaUsers(
-            state.assignedCMSUsers
-        )
+        const users = parseDomainUsersFromPrismaUsers(state.assignedCMSUsers)
 
         return users
     } catch (err) {
@@ -45,4 +46,4 @@ async function findStateAssignedUsers( client: PrismaTransactionType, stateCode:
     }
 }
 
-export {  findStateAssignedUsers }
+export { findStateAssignedUsers }
diff --git a/services/app-web/src/components/ChangeHistory/ChangeHistoryV2.tsx b/services/app-web/src/components/ChangeHistory/ChangeHistoryV2.tsx
@@ -25,7 +25,7 @@ type flatRevisions = UpdateInformation & {
 export const ChangeHistory = ({
     contract,
 }: ChangeHistoryProps): React.ReactElement => {
-    const {logAccordionEvent} = useTealium()
+    const { logAccordionEvent } = useTealium()
     const flattenedRevisions = (): flatRevisions[] => {
         const result: flatRevisions[] = []
 
@@ -164,7 +164,12 @@ export const ChangeHistory = ({
                 ),
                 expanded: false,
                 handleToggle: () => {
-                    logAccordionEvent({event_name: 'accordion_opened', heading: getUpdatedByDisplayName(r.updatedBy) ?? 'unknown', link_type:'link_other'})
+                    logAccordionEvent({
+                        event_name: 'accordion_opened',
+                        heading:
+                            getUpdatedByDisplayName(r.updatedBy) ?? 'unknown',
+                        link_type: 'link_other',
+                    })
                 },
                 id: dayjs(r.updatedAt).toISOString(),
             }

diff --git a/services/app-web/src/components/DataDetail/DataDetailContactField/DataDetailContactField.tsx b/services/app-web/src/components/DataDetail/DataDetailContactField/DataDetailContactField.tsx
@@ -40,8 +40,8 @@ export const DataDetailContactField = ({
                 target="_blank"
                 variant="external"
                 rel="noreferrer"
-                event_name='contact_click'
-                contact_method='email'
+                event_name="contact_click"
+                contact_method="email"
             >
                 {email}
             </LinkWithLogging>

diff --git a/services/app-web/src/components/FilterAccordion/FilterAccordion.tsx b/services/app-web/src/components/FilterAccordion/FilterAccordion.tsx
@@ -20,7 +20,7 @@ export const FilterAccordion = ({
     filterTitle,
     children,
 }: FilterAccordionPropType) => {
-    const {logAccordionEvent} = useTealium()
+    const { logAccordionEvent } = useTealium()
     /* multiple FilterSelect components are passed into the parent as children, and here we map
     over them to display them inside the accordion */
     const childFilters = React.Children.map(children, (child) => {
@@ -48,11 +48,15 @@ export const FilterAccordion = ({
             expanded: false,
             id: 'filterAccordionItems',
             handleToggle: () => {
-                logAccordionEvent({event_name: 'accordion_opened', heading: extractText(filterTitle), link_type:'link_other'})
-            }
+                logAccordionEvent({
+                    event_name: 'accordion_opened',
+                    heading: extractText(filterTitle),
+                    link_type: 'link_other',
+                })
+            },
         },
     ]
     return (
-    <Accordion items={accordionItems} className={styles.filterAccordion} />
+        <Accordion items={accordionItems} className={styles.filterAccordion} />
     )
 }
diff --git a/services/app-web/src/components/Header/Header.tsx b/services/app-web/src/components/Header/Header.tsx
@@ -33,7 +33,7 @@ export const Header = ({
     const { currentRoute: route } = useCurrentRoute()
 
     const handleLogout = async () => {
-        await logout({type: 'DEFAULT'})
+        await logout({ type: 'DEFAULT' })
         // no need to handle errors, logout will handle
     }
 

diff --git a/services/app-web/src/components/Modal/SessionTimeoutModal.tsx b/services/app-web/src/components/Modal/SessionTimeoutModal.tsx
@@ -19,7 +19,10 @@ export const SessionTimeoutModal = ({
     )
 
     const handleLogoutSession = async () => {
-        idleTimer.message({action: SESSION_ACTIONS.LOGOUT_SESSION_BY_CHOICE}, true)
+        idleTimer.message(
+            { action: SESSION_ACTIONS.LOGOUT_SESSION_BY_CHOICE },
+            true
+        )
     }
     const handleContinueSession = async () => {
         idleTimer.activate()

diff --git a/services/app-web/src/components/Modal/UnlockSubmitModal.tsx b/services/app-web/src/components/Modal/UnlockSubmitModal.tsx
@@ -127,7 +127,7 @@ export const UnlockSubmitModal = ({
     modalRef,
     setIsSubmitting,
 }: UnlockSubmitModalProps): React.ReactElement | null => {
-    const { logFormSubmitEvent} = useTealium()
+    const { logFormSubmitEvent } = useTealium()
     const [focusErrorsInModal, setFocusErrorsInModal] = useState(true)
     const [modalAlert, setModalAlert] = useState<
         GenericApiErrorProps | undefined
@@ -188,7 +188,7 @@ export const UnlockSubmitModal = ({
             heading: modalValues.modalHeading ?? 'unknown',
             form_name: modalType.toLowerCase(),
             event_name: 'form_field_submit',
-            link_type: 'link_other'
+            link_type: 'link_other',
         })
 
         switch (modalType) {

diff --git a/services/app-web/src/components/TealiumLogging/Link.tsx b/services/app-web/src/components/TealiumLogging/Link.tsx
@@ -18,12 +18,7 @@ type TealiumDataType = Omit<
 type LinkWithLoggingType = TealiumDataType & DefaultLinkProps
 const LinkWithLogging = (props: LinkWithLoggingType) => {
     const { logInternalLinkEvent } = useTealium()
-    const {
-        href,
-        onClick,
-        children,
-        ...rest
-    } = props
+    const { href, onClick, children, ...rest } = props
     return (
         <Link
             onClick={(e) => {

diff --git a/services/app-web/src/pages/App/App.tsx b/services/app-web/src/pages/App/App.tsx
@@ -50,7 +50,9 @@ function App({
     })
     const tealiumEnv = getTealiumEnv(environmentName)
     const newTealiumClient =
-        tealiumEnv === 'dev' ? devTealiumClient(isLocal) : tealiumClient(tealiumEnv)
+        tealiumEnv === 'dev'
+            ? devTealiumClient(isLocal)
+            : tealiumClient(tealiumEnv)
 
     return (
         <ErrorBoundary FallbackComponent={ErrorBoundaryRoot}>

diff --git a/services/app-web/src/pages/App/AppRoutes.tsx b/services/app-web/src/pages/App/AppRoutes.tsx
@@ -262,9 +262,9 @@ const CMSUserRoutes = ({
                         element={<SupportEmailsTable />}
                     />
                     <Route
-                    path={RoutesRecord.EDIT_STATE_ASSIGNMENTS}
-                    element={<EditStateAssign />}
-                />
+                        path={RoutesRecord.EDIT_STATE_ASSIGNMENTS}
+                        element={<EditStateAssign />}
+                    />
                 </Route>
                 <Route
                     path={RoutesRecord.SETTINGS}