Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCR-2501: Update copy on settings page #2747

Merged
merged 1 commit into from
Sep 17, 2024
Merged

MCR-2501: Update copy on settings page #2747

merged 1 commit into from
Sep 17, 2024

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Sep 13, 2024 •
edited
Loading

Summary

MCR-2501

  • On Division assignments tab (formally CMS users):
    • Change Family Name to Last name
    • Change Given Name to First name
    • All first and last name entries should be in sentence case
  • On the State assignments tab (formally state analysts):
    • Page header should be in sentence case State assignments
    • Update page description to say “Below is a list of the DMCO staff assigned to states.”
    • Add space after comma between emails

Related issues

Screenshots

Screenshot 2024-09-13 at 6 47 31 PM

Screenshot 2024-09-13 at 6 51 53 PM

Test cases covered

QA guidance

@JasonLin0991 JasonLin0991 marked this pull request as ready for review September 13, 2024 22:52
@pearl-truss pearl-truss self-requested a review September 17, 2024 13:59
pearl-truss
pearl-truss approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@pearl-truss pearl-truss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haworku haworku merged commit 9d87d7a into main Sep 17, 2024
28 checks passed
@haworku haworku deleted the jl-mcr-2501-update-copy-on-settings-page branch September 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearl-truss pearl-truss pearl-truss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonLin0991 @pearl-truss @haworku