MCR-4450: Update rate resolver to return questions field #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
commented
Oct 3, 2024
…to-return-questions-field' into jl-mcr-4450-update-rateResolver-to-return-questions-field
JasonLin0991
requested review from
macrael,
haworku,
pearl-truss and
mojotalantikite
haworku
approved these changes
Oct 3, 2024
JasonLin0991
deleted the
jl-mcr-4450-update-rateResolver-to-return-questions-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MCR-4450
rateResolverreturns questions similar tocontractResolver.fetchRateWithQuestionsthat includes thequestionsfield.NOTE: As a follow on ticket I wanted to rename all the existing
questionfor contract questions tocontractQuestionto better clarify which question type belongs to a rate and a contract. Separating it from this work will make it easier to review.Related issues
Screenshots
Test cases covered
fetchRate.test.ts'returns the questions on for a rate'QA guidance