MCR-4449: Rate create rate question response api #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
changed the title
haworku
reviewed
Oct 10, 2024
| @@ -701,7 +705,7 @@ type CreateRateQuestionPayload { | |||
| # question: Question! | |||
| #} | |||
|
|
|||
| input CreateContractQuestionResponseInput { | |||
| input CreateQuestionResponseInput { | |||
There was a problem hiding this comment.
Can you clarify in the naming or the comment this is a generic type it works for both rate and question responses. I think its worth clarifying because everything else seems to have distinct types (either contract or rate) for this API
haworku
approved these changes
Oct 10, 2024
haworku
reviewed
Oct 10, 2024
| @@ -39,15 +42,14 @@ export async function insertContractQuestionResponse( | |||
| include: questionInclude, | |||
| }) | |||
|
|
|||
| return questionPrismaToDomainType(result) | |||
| return contractQuestionPrismaToDomainType(result) | |||
| } catch (e) { | |||
| // Return a NotFoundError if prisma fails on the primary key constraint | |||
| // An operation failed because it depends on one or more records | |||
| // that were required but not found. | |||
| if (e.code === 'P2025') { | |||
There was a problem hiding this comment.
I said this to @macrael in an earlier PR, it seems brittle to hardcode these error codes in random postgres functions we should be using helper functions. seems like this is isMissingRelatedRecord or something like that because record to update doesnt exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MCR-4449
Related issues
Screenshots
Test cases covered
createRateQuestionResponse.test.ts'returns question response data''returns an error when attempting to create a response for a question that does not exist''returns an error if a cms user attempts to create a response for a rate question'QA guidance