-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix large dynamic tape issue #509
Conversation
That is illegal. |
We're not mutating it after being observed, we're initializing it? |
We are guaranteed to never update values in place? That was my assumption for why it had to be a mutable |
thinking this through: This technically overrides the Enzyme internal allocator in its entirety. We would only have a julia object internally if we needed to cache it for a tape. The tape should be immutable once initialized (technically we may memset it to 0 -- in fact in this very julia_allocator function), but otherwise once its value is set to actually preserve something, it is the same. We even attach invariant.group MD on it |
Co-authored-by: Valentin Churavy <[email protected]>
Codecov ReportBase: 74.87% // Head: 74.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 74.87% 74.61% -0.27%
==========================================
Files 17 17
Lines 5370 5370
==========================================
- Hits 4021 4007 -14
- Misses 1349 1363 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fixes #500