Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more precise memcpy tt #140

Merged
merged 1 commit into from
Jul 25, 2024
Merged

more precise memcpy tt #140

merged 1 commit into from
Jul 25, 2024

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Jul 25, 2024

Third arg is the size, and thus always an int.

@ZuseZ4 ZuseZ4 merged commit 675a9a8 into master Jul 25, 2024
4 of 5 checks passed
@ZuseZ4 ZuseZ4 deleted the memcpy-tt branch July 25, 2024 20:57
@wsmoses
Copy link
Member

wsmoses commented Jul 25, 2024

This should already be assumed why is this needed

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Jul 25, 2024

I was also surprised since I would have expected Enzyme core to handle this.
I had enzyme complaining about can not deduce type of memcpy in a specific case where I had given tt for the first two args (src and dst, both -1:ptr and -1:0 to -1:72 being float). So I added this and now it went away.
Let me see if I can reproduce it by undoing this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants