This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Remove unit conversion for bitrate from URL. URL is already in kbps #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Belchy06
added a commit
that referenced
this pull request
Sep 14, 2023
…369) (#370) (cherry picked from commit eb9a665) Co-authored-by: William Belcher <[email protected]>
Belchy06
added a commit
that referenced
this pull request
Sep 14, 2023
…369) (#372) (cherry picked from commit eb9a665) Co-authored-by: William Belcher <[email protected]>
Belchy06
added a commit
that referenced
this pull request
Sep 14, 2023
…369) (#371) (cherry picked from commit eb9a665) Co-authored-by: William Belcher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Setting the WebRTC bitrate in the URL would lead to the settings panel being incorrectly populated on stream restart.
Solution
The URL already specifies the bitrate in kbps so there is no need to do a unit conversion when populating settings panel.