clang-tidy: use container empty() method where applicable

Ericson2314 · Nov 10, 2024 · fd76732 · fd76732
1 parent 80af76d
commit fd76732
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -5,5 +5,6 @@ Checks:
   - modernize-*
   - readability-braces-around-statements
   - readability-else-after-return
+  - readability-container-size-empty
   - cppcoreguidelines-pro-type-cstyle-cast
 UseColor: true
diff --git a/src/nix-eval-jobs.cc b/src/nix-eval-jobs.cc
@@ -404,11 +404,11 @@ auto main(int argc, char **argv) -> int {
             evalSettings.pureEval = true;
         }
 
-        if (myArgs.releaseExpr == "") {
+        if (myArgs.releaseExpr.empty()) {
             throw UsageError("no expression specified");
         }
 
-        if (myArgs.gcRootsDir == "") {
+        if (myArgs.gcRootsDir.empty()) {
             printMsg(lvlError, "warning: `--gc-roots-dir' not specified");
         } else {
             myArgs.gcRootsDir = std::filesystem::absolute(myArgs.gcRootsDir);

diff --git a/src/worker.cc b/src/worker.cc
@@ -142,7 +142,7 @@ void worker(nix::ref<nix::EvalState> state, nix::Bindings &autoArgs,
                     /* Register the derivation as a GC root.  !!! This
                        registers roots for jobs that we may have already
                        done. */
-                    if (args.gcRootsDir != "") {
+                    if (args.gcRootsDir.empty()) {
                         nix::Path root =
                             args.gcRootsDir + "/" +
                             std::string(nix::baseNameOf(drv.drvPath));
@@ -159,8 +159,8 @@ void worker(nix::ref<nix::EvalState> state, nix::Bindings &autoArgs,
                     auto attrs = nlohmann::json::array();
                     bool recurse =
                         args.forceRecurse ||
-                        path.size() == 0; // Dont require `recurseForDerivations
-                                          // = true;` for top-level attrset
+                        path.empty(); // Dont require `recurseForDerivations
+                                      // = true;` for top-level attrset
 
                     for (auto &i :
                          v->attrs()->lexicographicOrder(state->symbols)) {