Fix debug logging in store #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodorok
force-pushed
the
store_debug_logging_fix
branch
from
f7a455b to
38bdfe4
Compare
The id was a primary key, that was only assigned after the flush was done. The format string being used was not a flexible one, it was changed to the newer kind of format string, and the printed debug message was changed to a more meaningful one, stating the report hash, and the source file path.
vodorok
force-pushed
the
store_debug_logging_fix
branch
from
38bdfe4 to
cbb093f
Compare
bruntib
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id was a primary key, that was only assigned after the flush was done. The format string being used was not a flexible one, it was changed to the newer kind of format string, and the printed debug message was changed to a more meaningful one, stating the report hash, and the source file path.