[fix] Eliminate unnecessary error logging #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During "CodeChecker store" the server checks the review status of reports. Review status may come from source code comments (e.g. // codechecker_suppress [core.DivideZero] This is false positive). The server needs to read the content of source files in order to find these comment sections. However, source code files are not uploaded to the server when both the following conditions hold: 1. They were uploaded earlier with the same content by a previous "CodeChecker store" action. 2. The client realizes that there is no source comment in the source file. In these cases the server is emitting an error which tells that the source file was not uploaded. This error message is definitely not necessary, since there is no review status comment that could be read by the server or it had been read in a previous storage. Since in practice there is a lot of such files, and the immense number of error logs results log files in gigabytes. This commit eliminates these error logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During "CodeChecker store" the server checks the review status of reports. Review status may come from source code comments (e.g. // codechecker_suppress [core.DivideZero] This is false positive). The server needs to read the content of source files in order to find these comment sections. However, source code files are not uploaded to the server when both the following conditions hold:
In these cases the server is emitting an error which tells that the source file was not uploaded. This error message is definitely not necessary, since there is no review status comment that could be read by the server or it had been read in a previous storage.
Since in practice there is a lot of such files, and the immense number of error logs results log files in gigabytes. This commit eliminates these error logs.