Display warning if the compilation database is empty #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the log level from info to warning when nothing was analyzed due to eg an empty compilation database. Fixes Ericsson#4222
|
The implementation is correct, but I whether we went far enough. When is analyzing an empty database desirable? Can we not emit an error with return code 1? |
whisperity
added
enhancement 🌟
analyzer 📈
|
In case of incremental analysis in could be valid providing an empty compilation database. |
|
Very well. I suppose we could emit an error when the input json is technically empty, but not at this point. |
Szelethus
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the log level from info to warning when
nothing was analyzed due to eg an empty
compilation database.
Fixes #4222