[fix] Creating new temporary directory for zip files #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
requested changes
May 6, 2024
| @@ -894,7 +894,18 @@ def main(args): | |||
| port, | |||
| product_name=product_name) | |||
|
|
|||
| zip_file_handle, zip_file = tempfile.mkstemp('.zip') | |||
| temp_dir = "/".join([args.input[0], "tmp"]) | |||
There was a problem hiding this comment.
Please, use the python pathlib for building file paths so the implementation is more platform independent.
| zip_file_handle, zip_file = tempfile.mkstemp('.zip') | ||
| temp_dir = "/".join([args.input[0], "tmp"]) | ||
| try: | ||
| if not os.path.exists(temp_dir): |
There was a problem hiding this comment.
What happens if temp_dir already exists?
whisperity
added
the
CLI 💻
whisperity
reviewed
May 7, 2024
| @@ -894,7 +894,16 @@ def main(args): | |||
| port, | |||
| product_name=product_name) | |||
|
|
|||
| zip_file_handle, zip_file = tempfile.mkstemp('.zip') | |||
| try: | |||
| temp_dir = tempfile.mkdtemp(suffix="tmp", dir=args.input[0]) | |||
There was a problem hiding this comment.
Suggested change
| temp_dir = tempfile.mkdtemp(suffix="tmp", dir=args.input[0]) | |
| temp_dir = tempfile.mkdtemp(suffix="-store", dir=args.input[0]) |
We could be explicit about the fact (for posthumous spelunking of crashes at least) that the directory was caused by a store command.
There was a problem hiding this comment.
Great idea, much more trackable.
| @@ -1007,3 +1016,4 @@ def main(args): | |||
| finally: | |||
| os.close(zip_file_handle) | |||
| os.remove(zip_file) | |||
| os.rmdir(temp_dir) | |||
There was a problem hiding this comment.
Is this the right approach?
https://docs.python.org/3/library/os.html#os.rmdir
If the directory does not exist or is not empty, a FileNotFoundError or an OSError is raised respectively.
There was a problem hiding this comment.
You are right. The deletion is not recursive in this way. I've already fixed it with using shutil.rmtree()
During the storage, the zip files should be stored in one of the report folders instead of /tmp. Storing huge zip files can cause storage space saturation in /tmp. CodeChecker store would create a new tmp directory in the first given report folder where the zip files can be stored temporarily.
bruntib
approved these changes
May 21, 2024
bruntib
added a commit
to bruntib/codechecker
that referenced
this pull request
May 28, 2024
In an earlier PR (Ericsson#4237) there was a development about placing temporary files in the report directory instead of /tmp, since some systems have limited resourced in the /tmp folder. This PR is a continuation of this work: some other temporary files during storage are put to the report folder.
bruntib
added a commit
to bruntib/codechecker
that referenced
this pull request
May 28, 2024
In an earlier PR (Ericsson#4237) there was a development about placing temporary files in the report directory instead of /tmp, since some systems have limited resourced in the /tmp folder. This PR is a continuation of this work: some other temporary files during storage are put to the report folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the storage, the zip files should be stored in one of the report folders instead of
/tmp. Storing huge zip files can cause storage space saturation in/tmp.CodeChecker storewould create a new tmp directory in the first given report folder where the zip files can be stored temporarily.