Fix a crash where config handlers were built with missing binaries #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original patch (that itroduces the crash): Ericsson#4179 Revert attempt in Ericsson#4238. The crash occurs because the original patch tries to create config handlers even if they are not supported. This is playing with fire already, but the crash occured when not even the analyzer binary is found. In this patch, these analyzers are skipped from checking if they have any checkers enabled.
bruntib
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original patch (that itroduces the crash):
#4179
Revert attempt in #4238.
The crash occurs because the original patch tries to create config handlers even if they are not supported. This is playing with fire already, but the crash occured when not even the analyzer binary is found.
In this patch, these analyzers are skipped from checking if they have any checkers enabled.