[cmd] Add --anywhere-on-report-path flag to CLI #4255
Conversation
bruntib
added
enhancement 🌟
CLI 💻
| report_filter.fileMatchesAnyPoint = args.anywhere_on_report_path | ||
| report_filter.componentMatchesAnyPoint = args.anywhere_on_report_path | ||
|
|
There was a problem hiding this comment.
I am not sure it is the best way to complement the report filter. Would it be better to add a new if statement to the parse_report_filter_offline() function where we can check the existence of the anywhere_on_report_path argument? Should we validate if the --file or --component are given first?
There was a problem hiding this comment.
Personally, I'm not a fan of double checking all arguments like this: if 'flag' in args and args.flag: do_something(). I would say that the command line arguments should be preprocessed at the very beginning, possibly through argparse actions in the long terms. We shouldn't even check/parse/transform them in lower layers of the code.
Checking if --file or --component exists is a good idea. Perhaps a warning log would do?
bruntib
force-pushed
the
anywhere_in_cli
branch
3 times, most recently
from
09fc1e6 to
f51a9ea
Compare
The "anywhere on report path" feature exists in the web GUI. This feature controls --component and --file filters in order to return reports of which the report path not only ends in, but goes through them. In this commit this feature is added to the CLI, too.
The "anywhere on report path" feature exists in the web GUI. This feature controls --component and --file filters in order to return reports of which the report path not only ends in, but goes through them.
In this commit this feature is added to the CLI, too.