[Fix] Report sorting in unique mode #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cservakt
added
API change 📄
bruntib
approved these changes
Jul 30, 2024
| @@ -1962,45 +1962,29 @@ def getRunResults(self, run_ids, limit, offset, sort_types, | |||
| ReportAnnotations.value)])).label(f"annotation_{col}") | |||
|
|
|||
| if report_filter.isUnique: | |||
| # A report annotation filter cannot set in WHERE clause if we | |||
There was a problem hiding this comment.
Suggested change
| # A report annotation filter cannot set in WHERE clause if we | |
| # A report annotation filter cannot be set in WHERE clause if we |
| @@ -1962,45 +1962,29 @@ def getRunResults(self, run_ids, limit, offset, sort_types, | |||
| ReportAnnotations.value)])).label(f"annotation_{col}") | |||
|
|
|||
| if report_filter.isUnique: | |||
| # A report annotation filter cannot set in WHERE clause if we | |||
| # use annotation parameters in aggregate functions to create | |||
| # pivot table. Instead filtering report annotations in WHERE | |||
There was a problem hiding this comment.
Suggested change
| # pivot table. Instead filtering report annotations in WHERE | |
| # a pivot table. Instead of filtering report annotations in WHERE |
| # clause, we should use HAVING clause only for filtering | ||
| # aggregate functions. | ||
| # TODO: Fixing report annotation filter in every report server | ||
| # enpoint function. |
There was a problem hiding this comment.
Suggested change
| # enpoint function. | |
| # endpoint function. |
| # aggregate functions. | ||
| # TODO: Fixing report annotation filter in every report server | ||
| # enpoint function. | ||
| report_filter_annotations = report_filter.annotations |
There was a problem hiding this comment.
Suggested change
| report_filter_annotations = report_filter.annotations | |
| annotations_backup = report_filter.annotations |
Maybe such a name could cause less misunderstanding compared to that one-character difference.
cservakt
force-pushed
the
report-sorting-unique
branch
from
9894fc7 to
41866cb
Compare
Fixing report sorting on unique mode. After modifying the DB schema in Ericsson#4089 PR, the unique mode query of getRunResults endpoint has been changed, therefore, the report sorting is not working properly. Now, the unique mode query is redesigned and it use row_number() function to filter unique reports correctly. Where clause is also modified. It is getting rid of report annotation filter. Filtering annotation remains in having clause.
cservakt
force-pushed
the
report-sorting-unique
branch
from
41866cb to
cc7e526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing report sorting on unique mode. After modifying the DB schema in #4089 PR, the unique mode query of getRunResults endpoint has been changed, therefore, the report sorting is not working properly.
Now, the unique mode query is redesigned and it use row_number() function to filter unique reports correctly. Where clause is also modified. It is getting rid of report annotation filter. Filtering annotation remains in having clause.