Various build fixes #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file And they are only a runtime dependency, no build dependency.
They will fail the build too easily with external headers and don't do what one would expect. Instead let autoconf figure out the right compiler flags for using a standard conformant C compiler.
owr_local_media_source.c: In function 'owr_local_media_source_get_pad':
owr_local_media_source.c:119:10: error: 'source' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (!gst_element_link(a, b)) \
^
owr_local_media_source.c:296:17: note: 'source' was declared here
GstElement *source, *capsfilter = NULL, *tee;
| @@ -18,11 +19,10 @@ LIBOPENWEBRTC_CFLAGS="-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 -DGLIB_VERSI | |||
| AC_SUBST(LIBOPENWEBRTC_CFLAGS) | |||
|
|
|||
| PKG_CHECK_MODULES(GLIB, [glib-2.0, gobject-2.0, gmodule-2.0, gthread-2.0]) | |||
| PKG_CHECK_MODULES(GSTREAMER, [gstreamer-1.0 >= 1.0.10 gstreamer-rtp-1.0 >= 1.0.10]) | |||
| PKG_CHECK_MODULES(NICE, [nice >= 0.1.4]) | |||
| PKG_CHECK_MODULES(GSTREAMER, [gstreamer-1.0 >= 1.0.10 gstreamer-rtp-1.0 >= 1.0.10 gstreamer-video-1.0 >= 1.0.10 gstreamer-app-1.0 >= 1.0.10]) | |||
There was a problem hiding this comment.
We probably require 1.4.x for glimagesink? I suppose we can conditionally build the OwrVideoRenderer.
There was a problem hiding this comment.
Yes, if glimagesink is a hard dependency. I don't know if you use other 1.2+ API
There was a problem hiding this comment.
glimagesink is used on all platforms but only by OwrVideoRenderer. We could make the build of that conditional on the gst version.
|
The build flag changes are fine. |
|
Updated to check for GStreamer >= 1.4 |
|
This should now be good to merge, it should build with your build scripts too |
|
I will land it as soon as I have tested it. |
|
Builds for me on OSX and iOS when using my buildscript fixes |
|
Landed all these, thanks. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will have to be tested with the build scripts on all platforms