Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #321 EnumNameSerializer #323

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

kwon37xi
Copy link
Contributor

With EnumNameSerializer, enum values are serialized with their name.
This serializer prevents reading wrong values when enum's order changed.

NathanSweet added a commit that referenced this pull request Jun 23, 2015
@NathanSweet NathanSweet merged commit 893b814 into EsotericSoftware:master Jun 23, 2015
@romix
Copy link
Collaborator

romix commented Jun 23, 2015

Question: The names are written using writeString(). Wouldn't it be better to write them using writeObject? In this case, Kryo could re-use these names, if references are enabled. This could be useful for big graphs.

NathanSweet added a commit that referenced this pull request Jun 23, 2015
@NathanSweet
Copy link
Member

Good point, done.

On Tue, Jun 23, 2015 at 8:53 PM, romix [email protected] wrote:

Question: The names are written using writeString(). Wouldn't it be better
to write them using writeObject? In this case, Kryo could re-use these
names, if references are enabled. This could be useful for big graphs.


Reply to this email directly or view it on GitHub
#323 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants