Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UDP recieving on Android 5.0+ #111

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

sylvia43
Copy link
Contributor

@sylvia43 sylvia43 commented Nov 4, 2015

Tested it, works great on my 5.0 device. This is a fix known by the community (#106, https://groups.google.com/forum/#!topic/kryonet-users/7l436tftBlo) but for some reason is not in the codebase.

@Kogs
Copy link

Kogs commented Nov 9, 2015

Please merge the Pull Request.

@Philanatidae
Copy link

Confirmed to work as expected on my Android 5.1 device.

@shanejansen
Copy link

This breaks kryonet when when running on an iOS device via RoboVM.

@CookedApps
Copy link

How do i use this patch in Android Studio with Gradle?

@sylvia43
Copy link
Contributor Author

sylvia43 commented Mar 4, 2016

@CookedApps you'd have to download the source, create a new module, and add the fix.

@CookedApps
Copy link

@anubiann00b Thanks for the reply, but i managed it by using jitpack.

@davjhan
Copy link

davjhan commented Mar 14, 2016

@CookedApps Could you explain to us how you did it through jitpack while we wait for this to get merged? Thanks!

@CookedApps
Copy link

@davjhan Sorry for my late answer!
In your build.gradle file:

  1. Add maven { url "https://jitpack.io" } to your repositories
  2. Add compile "com.github.anubiann00b:kryonet:b6b71d4" to your dependencies
    -> This refers to the specific commit (b6b71d4) by anubiann00b.

In my case i got a "multiple dex files" exception; so in this case ýou have to exclude kryo from kryonet and add it separately:

compile "com.esotericsoftware:kryo:3.0.3"
compile ("com.github.anubiann00b:kryonet:b6b71d4") {
       exclude module : 'kryo'
}

And thats it!

@davjhan
Copy link

davjhan commented Mar 22, 2016

@CookedApps
Hey! Thanks for the reply! I've tried your directions, but it ends in gradle syncing forever. If I look up the repo in the jitpack website, I get an error that says 'unauthorized'. Is there something I am missing here? Thanks again!
capture

@sylvia43
Copy link
Contributor Author

I'm assuming that's because Jitpack is compiling the project and Gradle is downloading it? It shouldn't take forever to sync more than once, right?

This URL works for me, even in a new browser: https://jitpack.io/#anubiann00b/kryonet/b6b71d4

@davjhan
Copy link

davjhan commented Mar 23, 2016

Thank you! I got it to work, i'm guessing it was either android studio or my internet connection. Thanks! also @anubiann00b , thank you for making the branch while this bug gets fixed!

@sylvia43
Copy link
Contributor Author

Glad I could help! 😄

@emmett-deen
Copy link

Does anyone have this fix in a jar file style release yet?

@midn1
Copy link

midn1 commented Sep 13, 2017

Come on, this request's been waiting for 2 years

@Microbius
Copy link

This project is more or less dead. But you are free to fork this project and fix the bugs you want !

@NathanSweet NathanSweet merged commit f9e4946 into EsotericSoftware:master Nov 9, 2017
@NathanSweet
Copy link
Member

@shanejansen breaks how? Is there a workaround?

@shanejansen
Copy link

shanejansen commented Nov 9, 2017

@NathanSweet This was a while ago so I don't remember exactly. I do remember that Kryonet would no longer work on iOS via RoboVM (discontinued) after making this change. I didn't really look into it so no workaround that I know of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

10 participants